-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable distro check for linux builds to fix failing builds #149
Conversation
This is a workaround for the issue described in brave/brave-browser#305
I just remembered there's already a patch for this same file, are they applied serially and do we have other files with more than 1 patch in brave-core/patches? |
This includes the previous patch contents. The pattern that I see in brave-core/patches is that it is 1 patch file per in-repo file. |
it isn't necessary to patch for this. Anything in |
Referenced issue is brave/brave-browser#305 |
some of the errors from the issue look like real problems.
sounds like these builds may have runtime errors on those platforms. Do we know what introduced them? |
I double-checked these, and packages are available for them. |
they are available, but are they part of a minimal install? If not are we including them as required deps in our packages? If we are sure everything works correctly then we should probably update the list instead of turning off the check |
Okay, I've adjusted the PACKAGE_FILTER in Afterwards I ran the create_dist target again, and took a look at the resulting deb file:
From this we can see that libz1g and libcairo-gobject2 are included in the dependencies. So it seems updating this would be the way forward. |
Closing in favor of patching the package list generation to include these new packages. |
Trigger ac after recurring donation
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Run a linux build after committed. Test that the packages are installable on Trusty, Xenial, Jessie, Sid, F27.
Reviewer Checklist: