Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Added check for Tab switcher on return flag #15136

Merged
merged 1 commit into from
Sep 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions android/brave_java_sources.gni
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ brave_java_sources = [
"../../brave/android/java/org/chromium/chrome/browser/sync/BraveSyncDevices.java",
"../../brave/android/java/org/chromium/chrome/browser/sync/settings/BraveManageSyncSettings.java",
"../../brave/android/java/org/chromium/chrome/browser/tabmodel/BraveTabCreator.java",
"../../brave/android/java/org/chromium/chrome/browser/tasks/BraveReturnToChromeUtil.java",
"../../brave/android/java/org/chromium/chrome/browser/toolbar/BraveHomeButton.java",
"../../brave/android/java/org/chromium/chrome/browser/toolbar/BraveIncognitoToggleTabLayout.java",
"../../brave/android/java/org/chromium/chrome/browser/toolbar/BraveToolbarManager.java",
Expand Down
4 changes: 4 additions & 0 deletions android/java/apk_for_test.flags
Original file line number Diff line number Diff line change
Expand Up @@ -581,3 +581,7 @@
-keep class org.chromium.chrome.browser.crash.BravePureJavaExceptionReporter {
public <init>(...);
}

-keep class org.chromium.chrome.browser.tasks.ReturnToChromeUtil {
*** shouldShowTabSwitcher(...);
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,14 @@

import org.chromium.base.annotations.JNINamespace;
import org.chromium.base.annotations.NativeMethods;
import org.chromium.chrome.browser.flags.CachedFlag;
import org.chromium.chrome.browser.flags.ChromeFeatureList;

@JNINamespace("chrome::android")
public abstract class BraveFeatureUtil {
public static final CachedFlag sTabSwitcherOnReturn =
new CachedFlag(ChromeFeatureList.TAB_SWITCHER_ON_RETURN, false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, I didn't know about CachedFlag!


public static void enableFeature(
String featureName, boolean enabled, boolean fallbackToDefault) {
BraveFeatureUtilJni.get().enableFeature(featureName, enabled, fallbackToDefault);
Expand Down
4 changes: 4 additions & 0 deletions android/java/org/chromium/chrome/browser/BraveHelper.java
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,8 @@ public static void maybeMigrateSettings() {
BravePrefServiceBridge.getInstance().setDesktopModeEnabled(false);
}
}

public static void cacheNativeFeatures() {
BraveFeatureUtil.sTabSwitcherOnReturn.cacheFeature();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@
import org.chromium.chrome.browser.ApplicationLifetime;
import org.chromium.chrome.browser.BraveAdFreeCalloutDialogFragment;
import org.chromium.chrome.browser.BraveAdaptiveCaptchaUtils;
import org.chromium.chrome.browser.BraveFeatureUtil;
import org.chromium.chrome.browser.BraveHelper;
import org.chromium.chrome.browser.BraveRelaunchUtils;
import org.chromium.chrome.browser.BraveRewardsHelper;
Expand Down Expand Up @@ -758,6 +759,7 @@ public void finishNativeInitialization() {
BraveVpnNativeWorker.getInstance().reloadPurchasedState();

BraveHelper.maybeMigrateSettings();
BraveHelper.cacheNativeFeatures();

PrefChangeRegistrar mPrefChangeRegistrar = new PrefChangeRegistrar();
mPrefChangeRegistrar.addObserver(BravePref.SCHEDULED_CAPTCHA_ID, this);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/* Copyright (c) 2022 The Brave Authors. All rights reserved.
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */

package org.chromium.chrome.browser.tasks;

import org.chromium.chrome.browser.BraveFeatureUtil;
import org.chromium.chrome.browser.flags.ChromeFeatureList;

public final class BraveReturnToChromeUtil {
public static boolean shouldShowTabSwitcher(final long lastBackgroundedTimeMillis) {
if (!BraveFeatureUtil.sTabSwitcherOnReturn.isEnabled()) {
return false;
}

return ReturnToChromeUtil.shouldShowTabSwitcher(lastBackgroundedTimeMillis);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ public void testClassesExist() throws Exception {
Assert.assertTrue(classExists("org/chromium/chrome/browser/omnibox/LocationBarMediator"));
Assert.assertTrue(
classExists("org/chromium/chrome/browser/omnibox/BraveLocationBarMediator"));
Assert.assertTrue(classExists("org/chromium/chrome/browser/tasks/ReturnToChromeUtil"));
}

@Test
Expand Down Expand Up @@ -420,6 +421,8 @@ public void testMethodsExist() throws Exception {
"onAssistantVoiceSearchServiceChanged", false, null));
Assert.assertTrue(methodExists("org/chromium/chrome/browser/omnibox/LocationBarMediator",
"shouldShowDeleteButton", false, null));
Assert.assertTrue(methodExists("org/chromium/chrome/browser/tasks/ReturnToChromeUtil",
"shouldShowTabSwitcher", true, boolean.class, long.class));
}

@Test
Expand Down
1 change: 1 addition & 0 deletions build/android/bytecode/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ java_binary("java_bytecode_rewriter") {
"//brave/build/android/bytecode/java/org/brave/bytecode/BravePureJavaExceptionReporterClassAdapter.java",
"//brave/build/android/bytecode/java/org/brave/bytecode/BraveQueryTileSectionClassAdapter.java",
"//brave/build/android/bytecode/java/org/brave/bytecode/BraveReaderModeManagerClassAdapter.java",
"//brave/build/android/bytecode/java/org/brave/bytecode/BraveReturnToChromeUtilClassAdapter.java",
"//brave/build/android/bytecode/java/org/brave/bytecode/BraveSearchEngineAdapterClassAdapter.java",
"//brave/build/android/bytecode/java/org/brave/bytecode/BraveSettingsLauncherImplClassAdapter.java",
"//brave/build/android/bytecode/java/org/brave/bytecode/BraveShareDelegateImplClassAdapter.java",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ public static ClassVisitor createAdapter(ClassVisitor chain) {
chain = new BravePureJavaExceptionReporterClassAdapter(chain);
chain = new BraveQueryTileSectionClassAdapter(chain);
chain = new BraveReaderModeManagerClassAdapter(chain);
chain = new BraveReturnToChromeUtilClassAdapter(chain);
chain = new BraveSearchEngineAdapterClassAdapter(chain);
chain = new BraveSettingsLauncherImplClassAdapter(chain);
chain = new BraveShareDelegateImplClassAdapter(chain);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
/* Copyright (c) 2022 The Brave Authors. All rights reserved.
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */

package org.brave.bytecode;

import org.objectweb.asm.ClassVisitor;

public class BraveReturnToChromeUtilClassAdapter extends BraveClassVisitor {
static String sReturnToChromeUtilClassName =
"org/chromium/chrome/browser/tasks/ReturnToChromeUtil";
static String sBraveReturnToChromeUtilClassName =
"org/chromium/chrome/browser/tasks/BraveReturnToChromeUtil";

public BraveReturnToChromeUtilClassAdapter(ClassVisitor visitor) {
super(visitor);

changeMethodOwner(sReturnToChromeUtilClassName, "shouldShowTabSwitcher",
sBraveReturnToChromeUtilClassName);
}
}