Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added accelerator for toggle sidebar #17373

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Added accelerator for toggle sidebar #17373

merged 1 commit into from
Feb 27, 2023

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Feb 27, 2023 •
edited
Loading

fix brave/brave-browser#27994

Ctrl+B(Cmd+B on macOS) toggles sidebar.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

SidebarBrowserTest.BasicTest
BraveBrowserCommandControllerTest.BraveCommandsEnableTest
AcceleratorTableTest.CheckBraveAccelerators

  1. Launch Brave
  2. Check sidebar is toggled by ctrl+b(or cmd+b on macOS)

@simonhong simonhong requested a review from a team as a code owner February 27, 2023 00:28
@simonhong simonhong self-assigned this Feb 27, 2023
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Feb 27, 2023
@simonhong simonhong force-pushed the add_shortcut_for_toggle_sidebar branch from ee49d7e to f52eb3f Compare February 27, 2023 00:37
fallaciousreasoning
fallaciousreasoning approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one comment

chromium_src/chrome/browser/ui/views/accelerator_table.cc Outdated Show resolved Hide resolved
@simonhong simonhong force-pushed the add_shortcut_for_toggle_sidebar branch from f52eb3f to afb1978 Compare February 27, 2023 00:59
goodov
goodov reviewed Feb 27, 2023
View reviewed changes
browser/ui/browser_commands.cc Outdated
@@ -277,6 +277,11 @@ void ToggleSidebarPosition(Browser* browser) {
!prefs->GetBoolean(prefs::kSidePanelHorizontalAlignment));
}

void ToggleSidebar(Browser* browser) {
auto* brave_browser_window = BraveBrowserWindow::From(browser->window());
Copy link
Member

@goodov goodov Feb 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please note how other hotkeys check browser value (not all, but still).
seems like MacOS is picky about this, please make sure we don't crash like we did here: #16916

you should either add if (browser) or DCHECK(browser);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the advice! Updated - https://github.com/brave/brave-core/compare/afb1978a4f991ebadca657ea6267eacb6b0eed3f..36dd7422b865bfe3025844b98b3115e576ea5b46

@simonhong
Added accelerator for toggle sidebar
36dd742 
fix brave/brave-browser#27994

Ctrl+B(Cmd+B on macOS) toggles sidebar.
@simonhong simonhong force-pushed the add_shortcut_for_toggle_sidebar branch from afb1978 to 36dd742 Compare February 27, 2023 07:00
@simonhong simonhong merged commit daab2bf into master Feb 27, 2023
@simonhong simonhong deleted the add_shortcut_for_toggle_sidebar branch February 27, 2023 10:58
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodov goodov goodov approved these changes

@fallaciousreasoning fallaciousreasoning fallaciousreasoning approved these changes

@sangwoo108 sangwoo108 Awaiting requested review from sangwoo108

Assignees

@simonhong simonhong

Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging this pull request may close these issues.

Add keyboard shortcut to show/hide sidebar
3 participants
@simonhong @goodov @fallaciousreasoning