Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "Copy clean link" from context menu on webpage when URL text (not link) is highlighted #17494

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Mar 6, 2023

Resolves brave/brave-browser#28881

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Steps from issue

@spylogsster spylogsster changed the title wip Support "Copy clean link" from context menu on webpage when URL text (not link) is highlighted Mar 7, 2023
@spylogsster spylogsster marked this pull request as ready for review March 7, 2023 14:40
@spylogsster spylogsster requested a review from a team as a code owner March 7, 2023 14:40
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src ++

test/filters/unit_tests.filter Show resolved Hide resolved
@spylogsster spylogsster merged commit 947d03e into master Mar 8, 2023
@spylogsster spylogsster deleted the brave-28881 branch March 8, 2023 07:34
@github-actions github-actions bot added this to the 1.51.x - Nightly milestone Mar 8, 2023
@AustinGitHub
Copy link

Question, is this a fix for this issue I just opened up? brave/brave-browser#29074 I am trying to find the source for why it was decided to change the keyboard shortcut to "copy clean link" automatically for users, this is a major regression as it disturbs the actual functionality of using copy/paste, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "Copy clean link" from context menu on webpage when URL text (not link) is highlighted
5 participants