Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC1155 support to NFT discovery #17778

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Conversation

nvonpentz
Copy link
Member

Resolves brave/brave-browser#29304

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Add a new account that has an ERC1155 token on a supported ETH network, or have such an account already and refresh the portfolio page. The ERC1155 token (which previously should not have been added to your portfolio) should have been auto discovered and displayed on the NFTs page.

@nvonpentz nvonpentz merged commit 916969f into master Mar 27, 2023
@nvonpentz nvonpentz deleted the nft-discovery-erc1155 branch March 27, 2023 20:24
@github-actions github-actions bot added this to the 1.51.x - Nightly milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support NFT discovery for ERC1155s
2 participants