Freetype crash regression test #18338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarolin
reviewed
May 4, 2023
renderer/test/font_browsertest.cc
Outdated
Comment on lines
42
to
47
| content::WebContents* web_contents() { | ||
| return browser()->tab_strip_model()->GetActiveWebContents(); | ||
| } | ||
|
|
||
| content::RenderFrameHost* primary_main_frame() { | ||
| return web_contents()->GetPrimaryMainFrame(); |
There was a problem hiding this comment.
Are these needed (and related header #includes)?
There was a problem hiding this comment.
Indeed they are not. Thanks!
Fixed in 539277fa27134081c164f645564b730b346ea0da.
The Brave 1.50.121 release crashed loading certain pages on Linux. Add a regression test based on an isolated reproduction. The issue seemed to be using the Google Noto Sans VF shipped as a system font by Fedora, Arch, and a few other distributions inside a `<select>` element. This adds a test page, and loads it as part of a browser test. The test page is minified from https://brave.com/ which also showed the issue. The font in question was reduced in fontforge to just lowercase latin glyphs, with all additional tables removed so save space. The result was included directly in the test page using a `data:` url. Resolves brave/brave-browser#29957
Fix css errors which were preventing the page from using the minimized font from the data: url. Unfortunately this revealed that the minimized version doesn't actually reproduce the problem; it was still falling back to the system font. The should be a stand-alone reproduction, at the expense of an 844 kB test file.
rillian
force-pushed
the
freetype-regression
branch
from
a3011f9
to
a7e8742
Compare
|
ci being weird. rebased, squashing fixups. |
brave-builds
added a commit
that referenced
this pull request
May 4, 2023
7 tasks
brave-builds
added a commit
that referenced
this pull request
May 4, 2023
7 tasks
kjozwiak
pushed a commit
that referenced
this pull request
May 8, 2023
Uplift of #18338 (squashed) to beta
kjozwiak
pushed a commit
that referenced
this pull request
May 8, 2023
Uplift of #18338 (squashed) to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a regression test for the release crash we saw on some Linux systems with Brave 1.50.121.
Note this requires a release build to reproduce, but does seem to trigger when such runs in ci, so this should work to catch a re-occurance.
Points for review:
Resolves brave/brave-browser#29957
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: