Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Hide NFTs Tab Setting in Portfolio Settings #18486

Merged
merged 1 commit into from
May 16, 2023

Conversation

Douglashdaniel
Copy link
Contributor

Description

Adds a hide NFTs tab check box to the Portfolio Settings menu

Resolves brave/brave-browser#30345

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Go to the Portfolio page and open the Portfolio Settings menu
  2. Uncheck the NFTs tab checkbox
  3. The segmented controls on the Portfolio Overview page
  4. Refresh the page, the selection should be persisted
  5. Switch the NFTs tab back on and go to the NFTs tab
  6. Uncheck the NFTs tab again, it should route back to the Assets page.
Screen.Recording.33.mov

@Douglashdaniel Douglashdaniel self-assigned this May 15, 2023
@Douglashdaniel Douglashdaniel requested review from a team as code owners May 15, 2023 19:05
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels May 15, 2023
@Douglashdaniel Douglashdaniel changed the title feat(wallet): Hide NFTs Tab Setting to Portfolio Settings feat(wallet): Hide NFTs Tab Setting in Portfolio Settings May 15, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l10n constant ++

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings ++

@Douglashdaniel Douglashdaniel merged commit 909a27c into master May 16, 2023
@Douglashdaniel Douglashdaniel deleted the add-hide-nfts-tab-setting branch May 16, 2023 19:35
@github-actions github-actions bot added this to the 1.53.x - Nightly milestone May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hide NFTs Tab Feature
5 participants