Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PowerShell Set-VpnConnectionIPsecConfiguration #18716

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Add PowerShell Set-VpnConnectionIPsecConfiguration #18716

merged 1 commit into from
Jun 2, 2023

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jun 1, 2023 •
edited by bsclifton
Loading

Resolves brave/brave-browser#30598

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Steps from issue
  • Additionally check on windows without PowerShell, win 7 for example if we support it

@spylogsster spylogsster marked this pull request as ready for review June 1, 2023 18:42
bsclifton
bsclifton reviewed Jun 1, 2023
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work great! Left comments about some small nits (so it's more obvious, less confusing)

bsclifton
bsclifton approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixups! Looks great! 😍

@brave-builds brave-builds mentioned this pull request Jun 1, 2023
Closed
7 tasks
brave-builds added a commit that referenced this pull request Jun 1, 2023
@brave-builds
Uplift of #18716 (squashed) to beta
b9b4b79
@spylogsster spylogsster enabled auto-merge (squash) June 1, 2023 20:23
@bsclifton bsclifton added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-linux-arm64 labels Jun 1, 2023
This was referenced Jun 1, 2023
Merged
Merged
@bsclifton bsclifton added this to the 1.54.x - Nightly milestone Jun 1, 2023
simonhong
simonhong approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ works perfectly! 👍🏼

@spylogsster spylogsster merged commit b3ca5aa into master Jun 2, 2023
@spylogsster spylogsster deleted the brave-30598 branch June 2, 2023 04:26
kjozwiak pushed a commit that referenced this pull request Jun 2, 2023
@spylogsster
Add PowerShell Set-VpnConnectionIPsecConfiguration (uplift of #18716) (…
d8f512e 
…#18721)

Add PowerShell Set-VpnConnectionIPsecConfiguration
kjozwiak pushed a commit that referenced this pull request Jun 2, 2023
@spylogsster
Add PowerShell Set-VpnConnectionIPsecConfiguration (uplift of #18716) (…
516d9ce 
…#18720)

Add PowerShell Set-VpnConnectionIPsecConfiguration
@spylogsster spylogsster mentioned this pull request Jun 8, 2023
Open
@bsclifton bsclifton mentioned this pull request Sep 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@simonhong simonhong simonhong approved these changes

Assignees

@spylogsster spylogsster

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.57.x - Release
3 participants
@spylogsster @bsclifton @simonhong