Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): handle nullable reward in eth_feeHistory (uplift to 1.56.x) #19492

Merged
merged 1 commit into from
Aug 1, 2023
Merged

fix(wallet): handle nullable reward in eth_feeHistory (uplift to 1.56.x) #19492

merged 1 commit into from
Aug 1, 2023

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jul 31, 2023 •
edited by kjozwiak
Loading

Uplift of #19481
Resolves brave/brave-browser#31959

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner July 31, 2023 10:14
@brave-builds brave-builds self-assigned this Jul 31, 2023
@brave-builds brave-builds added this to the 1.56.x - Release #7 milestone Jul 31, 2023
kjozwiak
kjozwiak approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.56.x approved 👍 QA has verified the PR on Nightly as per #19481 (comment).

@kjozwiak kjozwiak merged commit c19ca98 into 1.56.x Aug 1, 2023
5 checks passed
@kjozwiak kjozwiak deleted the pr19481_h/wallet/nullable-reward-fee-history_1.56.x branch August 1, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Milestone
1.56.x - Release #7
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @kjozwiak