Register wallet data files component only if user has created wallets #20741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrliou
force-pushed
the
wallet_perf
branch
4 times, most recently
from
4e433ef
to
104816e
Compare
yrliou
changed the title
yrliou
force-pushed
the
wallet_perf
branch
2 times, most recently
from
6233e43
to
2860903
Compare
yrliou
changed the title
supermassive
reviewed
Nov 2, 2023
supermassive
reviewed
Nov 2, 2023
StephenHeaps
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
iOS++.
Hit brave/brave-browser#34095 but also hit it on master so seems unrelated to this PR.
|
Remove needs-security-review flag and those assignees due to base::Unretained(this) which is removed now. |
josheleonard
suggested changes
Nov 3, 2023
...nents/brave_wallet_ui/page/screens/onboarding/create-password/onboarding-create-password.tsx
Outdated
Show resolved
Hide resolved
components/brave_wallet_ui/page/screens/onboarding/onboarding.routes.tsx
Outdated
Show resolved
Hide resolved
...let_ui/page/screens/onboarding/restore-from-recovery-phrase/restore-from-recovery-phrase.tsx
Outdated
Show resolved
Hide resolved
josheleonard
reviewed
Nov 3, 2023
...let_ui/page/screens/onboarding/restore-from-recovery-phrase/restore-from-recovery-phrase.tsx
Show resolved
Hide resolved
josheleonard
approved these changes
Nov 3, 2023
mkarolin
reviewed
Nov 3, 2023
| Your wallet is restoring... | ||
| </message> | ||
| <message name="IDS_YOUR_WALLET_IS_CREATING_PAGE_TITLE" desc="Text for a spinner page title during Brave Wallet creating. It is not displayed anywhere" translateable="false"> | ||
| Your wallet is creating... |
There was a problem hiding this comment.
Suggestions: Your wallet is being created... or Creating your wallet...
There was a problem hiding this comment.
Changed to Your wallet is being created..., thanks.
This PR does following things: - For normal users without wallet: wallet data files won't be registered. - For first time wallet users, wallet data files component will be registered when Create/ResotreWallet and ImportFromExternalWallet APIs are called, the finish callback of these APIs won't be run until wallet data files component is ready and content is parsed into BlockchainRegistry. - For existing wallet users, the behavior is unchanged, wallet data files component will continue to be registered and parsed upon startup. - Remove json sanitization on JSON files from brave wallet data files component served via component updater which is considered trusted data.
yrliou
force-pushed
the
wallet_perf
branch
3 times, most recently
from
49f8b9b
to
6e16623
Compare
…Desktop - The timing of registration is controlled by core backend - Remove RegisterWalletDataFilesComponentOnDemand in Android - Remove wallet_data_files_installer_android_util Authored by @AlexeyBarabash: - Added Android onboaring page fragment - Removed unused staff around Android's percentage progress while download Wallet component
github-actions
bot
added
CI/storybook-url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#33757
Resolves brave/brave-browser#30940
This PR does following things:
when Create/ResotreWallet and ImportFromExternalWallet APIs are called, the
finish callback of these APIs won't be run until wallet data files component
is ready and content is parsed into BlockchainRegistry.
component will continue to be registered and parsed upon startup.
files component served via component updater which is considered trusted data.
Note that if the installation of component or parsing failed, we won't retry and will unblock the APIs without error in this case.
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Screenshots:
Create New Wallet
Screen.Recording.27.mov
Import From Existing Wallet
Screen.Recording.28.mov
Restore From Seed Phrase
Screen.Recording.29.mov
Test Plan:
npm start -- --user_data_dir_name=PR20741or run the executable with--user-data-dir=some_path. (Should see a welcome page when started)Also, do the similar steps for testing
import from existing walletlike above video shows.