Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Url bar falsely showing insecure state (uplift to 1.63.x) #22380

Merged
merged 1 commit into from
Mar 1, 2024
Merged

[iOS] Url bar falsely showing insecure state (uplift to 1.63.x) #22380

merged 1 commit into from
Mar 1, 2024

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Feb 28, 2024 •
edited by kjozwiak
Loading

Uplift of #22343
Resolves brave/brave-browser#36024

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@soner-yuksel soner-yuksel added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Feb 28, 2024
@soner-yuksel soner-yuksel self-assigned this Feb 28, 2024
@soner-yuksel soner-yuksel requested a review from a team as a code owner February 28, 2024 17:05
@kjozwiak kjozwiak mentioned this pull request Feb 28, 2024
Closed
@kjozwiak kjozwiak added this to the 1.63.x - Release #4 milestone Mar 1, 2024
kjozwiak
kjozwiak approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.63.x approved 👍 QA has verified the PR on Nightly using 1.65.x as per #22343 (comment). QA went through a thorough check via brave/brave-ios#8778 (comment).

@kjozwiak kjozwiak merged commit 09f5cd3 into 1.63.x Mar 1, 2024
13 checks passed
@kjozwiak kjozwiak deleted the pr22343_ios_secure_content_state_1.63.x branch March 1, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@soner-yuksel soner-yuksel

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.63.x - Release #4
Development

Successfully merging this pull request may close these issues.
2 participants
@soner-yuksel @kjozwiak