Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News]: Bump Nala to fix ButtonMenu bug #25289

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Aug 22, 2024

Resolves brave/brave-browser#40621

This only has one change for Nala, which is the fix for the ButtonMenu:

brave/leo@765fc13...7de60c1

Note: The commit lives on a new 1.69 branch in Nala, not on main so we don't pull in any unnecessary changes.

This commit is the fix.

We can't uplift the Nala bump from 1.70.x because it has a bunch of color changes.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open Brave News on the NTP
  2. The ButtonMenu should have a 3 dot menu, not the text "Click Me"

@fallaciousreasoning fallaciousreasoning requested a review from a team as a code owner August 22, 2024 23:57
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Aug 22, 2024
@kjozwiak kjozwiak added this to the 1.69.x - Release #2 milestone Aug 23, 2024
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.71.24 Chromium: 128.0.6613.85 (Official Build) nightly (64-bit)
-- | --
Revision | 71ea50704534831db1a46c24098f0076eccfb120
OS | Windows 11 Version 23H2 (Build 22631.4037)

Using the STR/Cases outlined via #25289 (comment) & brave/brave-browser#40621 (comment), ensured that the button on the news articles is appearing as ... rather than Click me.

  • ensured that clicking on ... produced/displayed a context menu allowing you to remove/hide content
  • ensured that clicking on Hide content from [xyz] removes that particular publisher
    • also ensured that you have the ability to refresh the feed with the New content available. Reload? button
  • ensured that the correct button is still being displayed after opening/closing several NTP and viewing the News Feed
    • ensured restarting the browser several times still displays the correct button within the news feed
Example Example
news1 news3

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.69.x approved 👍 QA has verified the PR on Nightly via 1.71.x as per #25289 (comment).

@kjozwiak kjozwiak merged commit bdd67ac into 1.69.x Aug 26, 2024
16 checks passed
@kjozwiak kjozwiak deleted the bn-article-menu-hotfix-1.69 branch August 26, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants