Extensions protected urls 4928 #2779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Jul 5, 2019
| if (IsRestrictedUrl(document_url, error)) | ||
| return PageAccess::kDenied; | ||
|
|
||
| + if (IsBraveRestrictedUrl(document_url, extension_id_, location_, error)) { |
There was a problem hiding this comment.
per dm this patch can be removed by using an ExtensionRegistryObserver to add the withheld patterns in either OnExtensionLoaded or OnExtensionReady. At that point we can check extensions::PermissionsData::CanExecuteScriptEverywhere for the extension and decide whether or not to add it and no patch will be necessary
bridiver
reviewed
Jul 5, 2019
patches/extensions-browser-api-web_request-web_request_permissions.cc.patch
Outdated
Show resolved
Hide resolved
bridiver
reviewed
Jul 5, 2019
fmarier
force-pushed
the
extensions-protected-urls-4928
branch
from
e8b04d2
to
a28c1ff
Compare
fmarier
force-pushed
the
extensions-protected-urls-4928
branch
from
a28c1ff
to
a4e19bd
Compare
fmarier
force-pushed
the
extensions-protected-urls-4928
branch
from
a4e19bd
to
802d463
Compare
fmarier
force-pushed
the
extensions-protected-urls-4928
branch
from
802d463
to
4105f86
Compare
32 tasks
|
Superseded by #2946 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to fix brave/brave-browser#4928.
@bridiver Do you think an override is the best way to patch this?
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
The webRequest hack can manually tested using https://github.com/fmarier/webrequest-demo and the contentScript one using https://github.com/fmarier/contentscript-demo.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.