Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tab Page: when initialized from JS, force send updated data #2941

Closed
wants to merge 1 commit into from

Conversation

petemill
Copy link
Member

Fix brave/brave-browser#5249

Submitter Checklist:

Test Plan:

Specified in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@petemill petemill self-assigned this Jul 17, 2019
@imptrx
Copy link
Contributor

imptrx commented Jul 17, 2019

I am testing this on a debug build so everything happens in slow motion 🐌Current behavior is that NTP flashes with erroneous preferences and then re-renders correctly within a quarter of a second.
This will probably not be as apparent in a release build but just a heads up

also just realized we are getting background images twice:
NTP-back

@petemill
Copy link
Member Author

ok good to know, thanks @imptrx - I'll test with a debug build too then. I think we should just go ahead and do the proper fix then. I'll close this and experiment.

@petemill petemill closed this Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When navigating back new tab page doesn't load
2 participants