Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update search engine defaults for DE / AU / NZ / IE (uplift to 0.71.x) #3626

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Update search engine defaults for DE / AU / NZ / IE (uplift to 0.71.x) #3626

merged 1 commit into from
Oct 8, 2019

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Oct 8, 2019 •
edited
Loading

Uplift of #3591
Fixes brave/brave-browser#6187

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly. (Tested on a local build.)
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton
Merge pull request #3591 from brave/bsc-search-engine-default
684560a 
Update search engine defaults for DE / AU / NZ / IE
@bsclifton bsclifton added this to the 0.71.x - Dev milestone Oct 8, 2019
@bsclifton bsclifton requested a review from a team October 8, 2019 06:48
@bsclifton bsclifton self-assigned this Oct 8, 2019
@bsclifton bsclifton removed the request for review from bridiver October 8, 2019 06:53
@kjozwiak
Copy link
Member

kjozwiak commented Oct 8, 2019

Looks like the two failures were related to Publish xUnit test result report which is a known issue/failure and not related to this specific PR 👍

kjozwiak
kjozwiak approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.71.x approved after deliberating with @brave/uplift-approvers. As per #3626 (comment), the CI/Jenkins failures were due to Publish xUnit test result report which isn't due to this specific PR.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@bsclifton bsclifton merged commit 3f58d27 into 0.71.x Oct 8, 2019
@bsclifton bsclifton deleted the search-default-0.71.x branch October 8, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@bsclifton @kjozwiak