Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unittest fail on debug #372

Merged
merged 1 commit into from
Aug 31, 2018
Merged

Fix unittest fail on debug #372

merged 1 commit into from
Aug 31, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Aug 29, 2018

BraveThemeService should skip observing kBraveThemeType prefs because
it is not registered in unittest.

Close brave/brave-browser#881

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Run yarn test brave_unit_tests Release and yarn test brave_unit_tests

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

BraveThemeService should skip oversing kBraveThemeType prefs because
it is not registered in unittest.
@simonhong simonhong self-assigned this Aug 29, 2018
@simonhong simonhong changed the title Fix unittest fail on release Fix unittest fail on debug Aug 30, 2018
@simonhong simonhong requested a review from bbondy August 30, 2018 23:35
@bbondy bbondy merged commit 42237af into master Aug 31, 2018
@simonhong simonhong deleted the fix_unittest branch September 4, 2018 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some unittest failed with Check failed: prefs_->FindPreference(pref_name_). brave.theme.type not registered.
2 participants