Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve context of string language (0.71) #3777

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Improve context of string language (0.71) #3777

merged 1 commit into from
Oct 29, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Oct 23, 2019

Uplift of: #3739
Related: brave/brave-browser#6537

@ryanml ryanml added this to the 0.71.x - Beta milestone Oct 23, 2019
@ryanml ryanml requested a review from a team October 23, 2019 00:19
@ryanml ryanml self-assigned this Oct 23, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Oct 24, 2019 •
edited
Loading

Restarting android, iOS and macOS due to the following failures:

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Oct 28, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Oct 28, 2019 •
edited
Loading

Going to restart on macOS due to https://staging.ci.brave.com/job/brave-browser-build-pr/job/uplift-6537-71/1/execution/node/134/log/ as mentioned via #3777 (comment). Ignoring the ImportError: No module named httplib2 lint failures as those are known and shouldn't block uplift/merging.

@kjozwiak kjozwiak mentioned this pull request Oct 28, 2019
Merged
@NejcZdovc @ryanml
Merge pull request #3739 from bradleyrichter/patch-1
484a4c0 
Improve context of string language
@kjozwiak
Copy link
Member

Looks like lint failed due to ImportError: No module named httplib2 which is a known issue.

kjozwiak
kjozwiak approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.71.x approved after deliberating with @brave/uplift-approvers. As per #3777 (comment), the only remaining failure is related to ImportError: No module named httplib2 which is a known issue.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@ryanml ryanml merged commit 266b240 into 0.71.x Oct 29, 2019
@ryanml ryanml deleted the uplift-6537-71 branch October 29, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@ryanml ryanml

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanml @kjozwiak @NejcZdovc