Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.72.x] Fix alignment on Welcome page content #3943

Closed
wants to merge 1 commit into from

Conversation

cezaraugusto
Copy link
Contributor

Content was not centered causing a bad UI. This commit fix that.

fix brave/brave-browser#6846

Sibling PR #3940

@cezaraugusto cezaraugusto added this to the 0.72.x - Beta milestone Nov 8, 2019
@cezaraugusto cezaraugusto requested a review from a team November 8, 2019 18:56
@cezaraugusto cezaraugusto self-assigned this Nov 8, 2019
@kjozwiak
Copy link
Member

Looks this never really started and eventually timed out. Restarting.

Content was not centered causing a bad UI. This commit fix that.

fix brave/brave-browser#6846
@kjozwiak
Copy link
Member

Waiting till #3940 is finally merged into master. Looks like there's a few other changes that need to happen.

@kjozwiak
Copy link
Member

@cezaraugusto going to close this PR until #3940 has been completed and merged. The current process is to make sure that the master issue is reviewed/merged before creating uplifts into other channels.

@kjozwiak kjozwiak closed this Nov 15, 2019
@kjozwiak kjozwiak deleted the ca-6846-72 branch November 15, 2019 23:36
@kjozwiak kjozwiak removed this from the 1.1.x - Beta milestone Nov 15, 2019
@kjozwiak kjozwiak removed the request for review from a team November 15, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants