Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse version 2 of the ad catalog #3980

Merged
merged 3 commits into from
Nov 14, 2019
Merged

Parse version 2 of the ad catalog #3980

merged 3 commits into from
Nov 14, 2019

Conversation

moritzhaller
Copy link
Contributor

@moritzhaller moritzhaller commented Nov 12, 2019

Fixes: brave/brave-browser#5231

@tmancey @jsecretan I thought about the scope for this ticket and interpreted "Parse and save" now as adding the new fields to the catalog state but not persisting it in the database. Changing the sqlite schema and bundle would be part of another ticket, since functionality is preserved and the new catalog is parsed. E.g. persisting and handling conversions is part of ticket #6536. Handling day parts and priority are not in scope for either of those tickets.

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple little changes and to fix CI issue

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@tmancey tmancey self-requested a review November 12, 2019 16:48
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@moritzhaller moritzhaller changed the title Feature 5231 Parse version 2 of the ad catalog Nov 12, 2019
@moritzhaller moritzhaller self-assigned this Nov 12, 2019
@moritzhaller moritzhaller added this to the 0.74.x - Nightly milestone Nov 12, 2019
@tmancey tmancey force-pushed the feature-5231 branch 2 times, most recently from 863b279 to 99fc270 Compare November 12, 2019 17:05
@moritzhaller moritzhaller force-pushed the feature-5231 branch 5 times, most recently from 3acd1e8 to 2859218 Compare November 14, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse version 2 of the ad catalog
3 participants