-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse version 2 of the ad catalog #3980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple little changes and to fix CI issue
ba6c9ba
to
b639cef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
863b279
to
99fc270
Compare
3acd1e8
to
2859218
Compare
2859218
to
06a34d5
Compare
Fixes: brave/brave-browser#5231
@tmancey @jsecretan I thought about the scope for this ticket and interpreted "Parse and save" now as adding the new fields to the catalog state but not persisting it in the database. Changing the sqlite schema and bundle would be part of another ticket, since functionality is preserved and the new catalog is parsed. E.g. persisting and handling conversions is part of ticket #6536. Handling day parts and priority are not in scope for either of those tickets.
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.