Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting option for disabling tor component #4046

Merged
merged 6 commits into from
Dec 4, 2019
Merged

Add setting option for disabling tor component #4046

merged 6 commits into from
Dec 4, 2019

Commits on Dec 4, 2019

  1. Add setting option for disabling tor component 

    and did some code cleanup.
    @simonhong
    simonhong committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    77b1453 View commit details
    Browse the repository at this point in the history

  2. Alphabetize the extension setting options

    @simonhong
    simonhong committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    988d9f2 View commit details
    Browse the repository at this point in the history

  3. Don't show tor toggle option if tor feature is not built

    @simonhong
    simonhong committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    84ef437 View commit details
    Browse the repository at this point in the history

  4. Don't change IsTorDisabled() during the runtime 

    Tor enabling change should only affect to browser after relaunching.
To cache user's change before relaunching, new kTorDisabledAtNextLaunching
pref value is introduced.
    @simonhong
    simonhong committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    7fafcb9 View commit details
    Browse the repository at this point in the history

  5. Don't use pref for IsTorDisabled() 

    To check whether tor is enabled or not, tor component registration is
used instead of pref value because user can change pref via settings.
With this, we don't need to another prefs to check user changed or not.
    @simonhong
    simonhong committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    744f854 View commit details
    Browse the repository at this point in the history

  6. Don't need to restart after changing tor option 

    Browsr commands will be updated after changing tor option.
If user turns it off, tor component will be removed at the next
launching. If there is already opened tor window, it can be used.
But, user can't create new tor window anymore.
    @simonhong
    simonhong committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    3e01e1f View commit details
    Browse the repository at this point in the history