Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 79.0.3945.56 to Chromium 79.0.3945.70 (1.2.x) #4153

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Dec 6, 2019

Fixes brave/brave-browser#7213
Related PR: brave/brave-browser#7232
Uplift from #4141

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Upgrade from Chromium 79.0.3945.56 to Chromium 79.0.3945.70
@mkarolin
Copy link
Collaborator Author

mkarolin commented Dec 6, 2019

Only publishing test results to S3 failed during CI run.

@mkarolin mkarolin requested a review from a team December 6, 2019 04:45
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.2.x approved after deliberating with @brave/uplift-approvers. As @mkarolin mentioned, the only failure is related to the test results not being updated into S3 which is a known intermittent issue. Please make sure that correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 1a963dc into 1.2.x Dec 6, 2019
@kjozwiak kjozwiak deleted the 79.0.3945.70-1.2.x branch December 6, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants