Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Copy for "Allow conversion tracking" in Brave Ads "Ads Settings" #4416

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jan 23, 2020

Fixes brave/brave-browser#7887
Requires #4253

Submitter Checklist:

Test Plan:

Confirm Copy has changed. Please see brave/brave-browser#7887 for new Copy.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey merged commit 4a504f0 into master Jan 23, 2020
@tmancey tmancey deleted the issues/7887 branch January 23, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Copy for "Allow conversion tracking" in Brave Ads "Ads Settings"
3 participants