Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP: Use solid color for topSites tiles background #4424

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Conversation

cezaraugusto
Copy link
Contributor

Fix brave/brave-browser#6642

Screen Shot 2020-01-24 at 12 48 15 PM

Submitter Checklist:

Test Plan:

NTP topSites should have a white, opaque background (see screenshot).

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@cezaraugusto cezaraugusto added feature/newtab CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Jan 24, 2020
@cezaraugusto cezaraugusto self-assigned this Jan 24, 2020
@cezaraugusto cezaraugusto added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Jan 24, 2020
@cezaraugusto
Copy link
Contributor Author

Since this change is only a CSS tweak, added CI/skip for macOS and Windows as well.

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like small PRs!

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++!

@bsclifton bsclifton merged commit 9a49f05 into master Jan 24, 2020
@bsclifton bsclifton deleted the ca-6642 branch January 24, 2020 17:57
@bsclifton bsclifton added this to the 1.5.x - Nightly milestone Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/newtab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New tab page top sites need to have an opaque, white background
3 participants