Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade mixed content connection #4537

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Upgrade mixed content connection #4537

merged 1 commit into from
Feb 14, 2020

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Feb 6, 2020 •
edited by bsclifton
Loading

Fixes brave/brave-browser#4381

Submitter Checklist:

Test Plan:

  1. Open https://mixed.badssl.com
  2. Click the padlock icon and make sure it's marked as secure:
    Screenshot from 2020-02-14 13-59-12
  3. Open the devtools console and verify that the insecure connections have been upgraded:
    Screenshot from 2020-02-14 13-59-31

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jonathanKingston jonathanKingston changed the title Bug 4381 Upgrade mixed content connection Feb 7, 2020
@iefremov
Copy link
Contributor

@fmarier could you please take a look?

@fmarier fmarier mentioned this pull request Feb 13, 2020
Closed
@fmarier
Copy link
Member

fmarier commented Feb 14, 2020

CI looks good: #4639

@fmarier
Copy link
Member

fmarier commented Feb 14, 2020

Added a test plan and confirmed that it works.

@fmarier fmarier added this to the 1.6.x - Nightly milestone Feb 14, 2020
@fmarier fmarier merged commit 86bf5ed into brave:master Feb 14, 2020
@fmarier
Copy link
Member

fmarier commented Feb 14, 2020

Thanks @jonathanKingston !

@diracdeltas diracdeltas mentioned this pull request Feb 14, 2020
Closed
@bbondy bbondy modified the milestones: 1.6.x - Beta, 1.7.x - Dev Mar 10, 2020
bsclifton added a commit that referenced this pull request Apr 8, 2020
@bsclifton
Fix problem where HTTPSE toggle doesn't work (always upgrades)
50c26ca 
Fixes brave/brave-browser#9099
Unfixes brave/brave-browser#4381

--------

Revert "Merge pull request #4537 from jonathanKingston/bug-4381"

This reverts commit 86bf5ed, reversing
changes made to affeac4.
This was referenced Apr 8, 2020
Closed
Closed
Closed
@fmarier fmarier mentioned this pull request May 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iefremov iefremov iefremov left review comments

@fmarier fmarier fmarier approved these changes

Assignees

@jonathanKingston jonathanKingston

Labels
None yet
Projects
None yet
Milestone
1.7.x - Release
Development

Successfully merging this pull request may close these issues.

[feature request] auto-upgrade mixed content
4 participants
@jonathanKingston @iefremov @fmarier @bbondy