Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make wayback url request to use per-profile SharedLoaderFactory (uplift to 1.4.x) #4769

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Make wayback url request to use per-profile SharedLoaderFactory (uplift to 1.4.x) #4769

merged 1 commit into from
Mar 2, 2020

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Feb 27, 2020 •
edited
Loading

Uplift of #4763
Fixes brave/brave-browser#8419

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton bsclifton requested a review from a team February 27, 2020 16:01
@bsclifton bsclifton self-assigned this Feb 27, 2020
@bsclifton bsclifton changed the title Uplift of #4763 (squashed) to release Make wayback url request to use per-profile SharedLoaderFactory (uplift to 1.4.x) Feb 27, 2020
@bsclifton bsclifton removed the request for review from simonhong February 27, 2020 16:01
@kjozwiak
Copy link
Member

Restarting Win x64 due to build failing as per https://ci.brave.com/job/brave-browser-build-pr/job/pr4763_issue_8419_wayback_1.4.x/1/execution/node/459/log/.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Feb 27, 2020
@simonhong
Copy link
Member

I think windows build is completed but got below at the end. It seems CI related error?

09:41:26  Cannot contact i-0b1eb13425375719d: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@41f7f5c5:i-0b1eb13425375719d": Remote call on i-0b1eb13425375719d failed. The channel is closing down or has closed down
09:46:33  Could not connect to i-0b1eb13425375719d to send interrupt signal to process

kjozwiak
kjozwiak approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.4.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any failures. QA went through the PR as per #4763 (comment). Please make sure that the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 4aaa606 into 1.4.x Mar 2, 2020
@kjozwiak kjozwiak deleted the pr4763_issue_8419_wayback_1.4.x branch March 2, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@bsclifton bsclifton

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.4.x - Release Hotfix 1
Development

Successfully merging this pull request may close these issues.
4 participants
@bsclifton @kjozwiak @simonhong @brave-browser-releases