Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes inconsistent conversion dates in logs - 1.7.x #4951

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 16, 2020

Uplift of #4945
Resolves brave/brave-browser#8689

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.7.x - Beta milestone Mar 16, 2020
@tmancey tmancey requested a review from a team March 16, 2020 12:13
@tmancey tmancey self-assigned this Mar 16, 2020
@tmancey tmancey changed the title Fixes inconsistent conversion dates in logs Fixes inconsistent conversion dates in logs - 1.7.x Mar 16, 2020
@kjozwiak
Copy link
Member

Looks like Publish xUnit failed for both test-unit and test-browser on macOS. However, these issues are known intermittent and none blocking.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.7.x approved after deliberating with @brave/uplift-approvers. As per #4951 (comment), the only failure was due to Publish xUnit failing for both test-unit and test-browser on macOS. However, this is an intermittent issue that's not related to this particular PR. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 5bcbdd4 into 1.7.x Mar 17, 2020
@kjozwiak kjozwiak deleted the issues/8689-1.7.x branch March 17, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants