Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes inconsistent conversion dates in logs - 1.5.x #4952

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Fixes inconsistent conversion dates in logs - 1.5.x #4952

merged 1 commit into from
Mar 17, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 16, 2020 •
edited by kjozwiak
Loading

Uplift of #4945
Resolves brave/brave-browser#8689

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.5.x - Release milestone Mar 16, 2020
@tmancey tmancey requested a review from a team March 16, 2020 12:16
@tmancey tmancey self-assigned this Mar 16, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Mar 16, 2020 •
edited
Loading

Looks like build failed on android as per https://ci.brave.com/job/brave-browser-build-pr/job/issues%252F8689-1.5.x/2/execution/node/267/log/.

Looks like build failed on iOS as per https://ci.brave.com/job/brave-browser-build-pr/job/issues%252F8689-1.5.x/2/execution/node/437/log/.

Looks like build failed on linux as per https://ci.brave.com/job/brave-browser-build-pr/job/issues%252F8689-1.5.x/2/execution/node/234/log/

Looks like build failed on macOS as per https://ci.brave.com/job/brave-browser-build-pr/job/issues%252F8689-1.5.x/2/execution/node/535/log/

Looks like build failed on Win 10 x64 as per https://ci.brave.com/job/brave-browser-build-pr/job/issues%252F8689-1.5.x/2/execution/node/344/log/

@tmancey mind taking a look? I can restart but figured you could take a look as it's basically failing build on each platform so this doesn't seem like an intermittent issue.

@kjozwiak
Copy link
Member

Android failed the build step as per https://ci.brave.com/job/brave-browser-build-pr/job/issues%252F8689-1.5.x/3/execution/node/259/log/. Looks like contacting https://crates.io timed out which makes sense as Heroku was having issues earlier in the day.

Same issue on Linux as mentioned above re: https://crates.io.

Going to restart Linux and Android.

@kjozwiak kjozwiak added CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Mar 16, 2020
kjozwiak
kjozwiak approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.5.x approved after deliberating with @brave/uplift-approvers. Both Jenkins and Travis passed without any failures after a few restarts. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit e23d734 into 1.5.x Mar 17, 2020
@kjozwiak kjozwiak deleted the issues/8689-1.5.x branch March 17, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
bug CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/ads
Projects
None yet
Milestone
1.5.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak