Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload active tab when widevine library is ready to use #4978

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 18, 2020

Resolves brave/brave-browser#4646

Submitter Checklist:

Test Plan:

See STR in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 1.8.x - Nightly milestone Mar 18, 2020
@simonhong simonhong self-assigned this Mar 18, 2020
@iefremov iefremov self-requested a review March 19, 2020 10:06
@simonhong
Copy link
Member Author

Merged because only test-security test was failed.

@simonhong simonhong merged commit 61836ff into master Mar 19, 2020
@simonhong simonhong deleted the issue_4646_widevine branch March 19, 2020 22:40
brave-builds pushed a commit that referenced this pull request Mar 24, 2020
@kjozwiak
Copy link
Member

@simonhong I don't think this is working 100% and is still reproducible. Went through the above change with the following builds:

Brave | 1.8.40 Chromium: 81.0.4044.69 (Official Build) nightly (64-bit)
-- | --
Revision | 6813546031a4bc83f717a2ef7cd4ac6ec1199132-refs/branch-heads/4044@{#776}
OS | macOS Version 10.15.3 (Build 19D76)
Brave | 1.8.40 Chromium: 81.0.4044.69 (Official Build) nightly (64-bit)
-- | --
Revision | 6813546031a4bc83f717a2ef7cd4ac6ec1199132-refs/branch-heads/4044@{#776}
OS | Windows 10 OS Version 1909 (Build 18363.720)

Looks like the Pardon the interruption error which mentions that the component needs to be updated is still appearing as per the following:

netflixComponent

With macOS, you'll still get the above message but the page will eventually refresh automatically and start playing the content as per the following example:

netflixComponent

However, on Win 10 x64, it doesn't automatically fresh the page and the above Pardon the interruption error is visible even after refreshing several times. You'll basically need to restart Brave to get Netflix working. Example:

netflixWin

@btlechowski also ran into the above issues on Windows but I'll let him comment 👍

@simonhong @bsclifton this PR seems to improve macOS but it still seems to be broken on Windows. As brave/brave-browser#4646 is labelled as Win specific, it doesn't improve the situation on Win.

@btlechowski
Copy link

btlechowski commented Mar 25, 2020

On Windowis, the original issue brave/brave-browser#4646 (comment) mentions that page reload fixed the issue. This is not the case with the issue @kjozwiak and I are seeing as reload does not fix the issue.
I noticed that the widevine component fails to download.
I logged brave/brave-browser#8862.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

follow up - CDM utility process not starting when tab triggers Widevine install in new profile
4 participants