-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload active tab when widevine library is ready to use #4978
Conversation
9f3bc07
to
9e09404
Compare
9e09404
to
ff22a06
Compare
ff22a06
to
7bb0a95
Compare
7bb0a95
to
cc517d5
Compare
Merged because only |
@simonhong I don't think this is working 100% and is still reproducible. Went through the above change with the following builds:
Looks like the With However, on @btlechowski also ran into the above issues on @simonhong @bsclifton this PR seems to improve macOS but it still seems to be broken on Windows. As brave/brave-browser#4646 is labelled as Win specific, it doesn't improve the situation on Win. |
On Windowis, the original issue brave/brave-browser#4646 (comment) mentions that page reload fixed the issue. This is not the case with the issue @kjozwiak and I are seeing as reload does not fix the issue. |
Resolves brave/brave-browser#4646
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
See STR in issue
Reviewer Checklist:
After-merge Checklist:
changes has landed on.