Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync duplicated object id migration (3) #5139

Merged
merged 3 commits into from
Apr 10, 2020
Merged

Sync duplicated object id migration (3) #5139

merged 3 commits into from
Apr 10, 2020

Commits on Apr 9, 2020

  1. Recreate bookmarks with duplicated object_id including nested in dupl… 

    …icated folders; fixes brave-browser#8358
    @AlexeyBarabash @bsclifton
    AlexeyBarabash authored and bsclifton committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    ca3c6e5 View commit details
    Browse the repository at this point in the history

  2. Updated test for recreating bookmarks with duplicated object_id inclu… 

    …ding nested in duplicated folders
    @AlexeyBarabash @bsclifton
    AlexeyBarabash authored and bsclifton committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    9f59bfb View commit details
    Browse the repository at this point in the history

  3. Put migration of sync data behind the overall feature flag 

    - Prevents brave/brave-browser#9110 (or similar) from happening
- Added unit test to ensure migration not done if sync disabled
    @bsclifton
    bsclifton committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    b631e74 View commit details
    Browse the repository at this point in the history