Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed crash when user tries to install ipfs extension from setting #5205

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Fixed crash when user tries to install ipfs extension from setting #5205

merged 1 commit into from
Apr 10, 2020

Commits on Apr 9, 2020

  1. Fixed crash when user tries to install ipfs extension from setting 

    When extension install is requested, install dialog is launched.
So far, we requsted un-parented install dialog.
On linux, custom frame is not allowed for un-parented dialog.
Only platform-native frame is used for it. The problem was
install dialog tries to set title to custom frame. So, seg fault
happened only on linux. And Windows with classic theme will have
same issue. On macOS and Windows with aero, crash doesn't happen.
But, un-parented dialog has title area that looks ugly.
    @simonhong
    simonhong committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    4cb815f View commit details
    Browse the repository at this point in the history