Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes tap image not showing every time #5243

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Fixes tap image not showing every time #5243

merged 1 commit into from
Apr 14, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 14, 2020

Resolves brave/brave-browser#8964

Submitter Checklist:

Test Plan:

  • enable rewards
  • go to rewards page
  • make sure that tap asset is always shown

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added feature/rewards CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Apr 14, 2020
@NejcZdovc NejcZdovc added this to the 1.9.x - Nightly milestone Apr 14, 2020
@NejcZdovc NejcZdovc requested review from ryanml and a team April 14, 2020 06:27
@NejcZdovc NejcZdovc self-assigned this Apr 14, 2020
@@ -3,7 +3,7 @@
* You can obtain one at http://mozilla.org/MPL/2.0/. */

import * as React from 'react'
import tapBg from './assets/tap-bg.svg'
import tapBg from './assets/tap_bg.svg'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to the PR, changed for consistency

@NejcZdovc
Copy link
Contributor Author

CI failed on known issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sometimes TAP image isn't shown
2 participants