Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shows both memo and address for applicable assets [Binance] (1.8) #5476

Merged
merged 1 commit into from
May 7, 2020
Merged

Shows both memo and address for applicable assets [Binance] (1.8) #5476

merged 1 commit into from
May 7, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented May 6, 2020 •
edited by kjozwiak
Loading

Uplift of: #5465

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@ryanml
Merge pull request #5465 from brave/fix-9605
abc1552 
Shows both memo and address for applicable assets [Binance]
@ryanml ryanml added this to the 1.8.x - Release Hotfix 2 milestone May 6, 2020
@ryanml ryanml requested a review from a team May 6, 2020 17:12
@ryanml ryanml self-assigned this May 6, 2020
@kjozwiak
Copy link
Member

kjozwiak commented May 6, 2020 •
edited
Loading

Restarting macOS as the build process failed as per https://ci.brave.com/job/pr-brave-browser-fix-9605-1.8/1/execution/node/234/log/

14:13:58  FAILED: obj/brave/browser/download/download/brave_download_item_model.o

Restarting Win x64 as it failed to fetch the source as per https://ci.brave.com/job/pr-brave-browser-fix-9605-1.8/1/execution/node/100/log/.

Travis also failed due to TEST_SUITE=test-security because of the yargs-parser npm package which is a known issue and not blocking uplift.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels May 6, 2020
kjozwiak
kjozwiak approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.8.x approved after deliberating with @brave/uplift-approvers. QA verified the PR on Nightly as per #5465 (comment). Ensured that the issue was moved into the appropriate milestone.

@kjozwiak kjozwiak merged commit 3540979 into 1.8.x May 7, 2020
@kjozwiak kjozwiak deleted the fix-9605-1.8 branch May 7, 2020 03:07
bsclifton pushed a commit that referenced this pull request May 7, 2020
@kjozwiak @bsclifton
Merge pull request #5476 from brave/fix-9605-1.8
40a8c83 
Shows both memo and address for applicable assets [Binance] (1.8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@ryanml ryanml

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/crypto-widgets
Projects
None yet
Milestone
1.8.x - Release Hotfix 2
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanml @kjozwiak