-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement publisher list v4 #5568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenparsing
force-pushed
the
ksmith-publishers-v4
branch
9 times, most recently
from
May 20, 2020 15:07
305325d
to
3d147a2
Compare
zenparsing
commented
May 20, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/database/database_server_publisher_info.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/publisher/server_publisher_fetcher.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/publisher/server_publisher_fetcher.cc
Outdated
Show resolved
Hide resolved
zenparsing
force-pushed
the
ksmith-publishers-v4
branch
12 times, most recently
from
May 22, 2020 19:30
e8dfc46
to
51bff19
Compare
zenparsing
force-pushed
the
ksmith-publishers-v4
branch
5 times, most recently
from
May 26, 2020 15:59
6c95376
to
1d3d685
Compare
NejcZdovc
reviewed
Jun 30, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/database/database_server_publisher_info.cc
Outdated
Show resolved
Hide resolved
NejcZdovc
reviewed
Jun 30, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/database/database_server_publisher_info.h
Outdated
Show resolved
Hide resolved
NejcZdovc
reviewed
Jun 30, 2020
NejcZdovc
reviewed
Jun 30, 2020
NejcZdovc
reviewed
Jun 30, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/request/request_util.h
Outdated
Show resolved
Hide resolved
NejcZdovc
reviewed
Jun 30, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/request/request_publisher.cc
Outdated
Show resolved
Hide resolved
NejcZdovc
reviewed
Jun 30, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/publisher/publisher_status_helper.cc
Show resolved
Hide resolved
NejcZdovc
reviewed
Jun 30, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/publisher/publisher_status_helper.cc
Show resolved
Hide resolved
NejcZdovc
reviewed
Jun 30, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/publisher/publisher_status_helper.cc
Show resolved
Hide resolved
NejcZdovc
reviewed
Jun 30, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/publisher/publisher_status_helper.cc
Show resolved
Hide resolved
NejcZdovc
reviewed
Jun 30, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/publisher/publisher.h
Outdated
Show resolved
Hide resolved
NejcZdovc
reviewed
Jun 30, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/publisher/publisher_prefix_list_updater.cc
Outdated
Show resolved
Hide resolved
zenparsing
force-pushed
the
ksmith-publishers-v4
branch
4 times, most recently
from
July 1, 2020 15:45
2157e9a
to
1524051
Compare
|
zenparsing
force-pushed
the
ksmith-publishers-v4
branch
4 times, most recently
from
July 4, 2020 17:10
24d0c02
to
e073268
Compare
fmarier
approved these changes
Jul 6, 2020
NejcZdovc
approved these changes
Jul 6, 2020
zenparsing
force-pushed
the
ksmith-publishers-v4
branch
from
July 7, 2020 11:59
e073268
to
5a8e84e
Compare
CI failed due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#9502
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
This PR modifies how publisher status and banner information is retrieved and stored on the client. Instead of downloading the entire publisher list dataset and storing that dataset in the rewards database, we will now download a small "index" of publishers and then download publisher data for individual publishers as-needed. There should be no user-visible changes, but existing test cases that involve publisher statuses or banner data should be checked for regressions.
Basic functionality test
Flags:
vmodule
entries can be used).Reviewer Checklist:
After-merge Checklist:
changes has landed on.