Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement publisher list v4 #5568

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Implement publisher list v4 #5568

merged 1 commit into from
Jul 7, 2020

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented May 15, 2020

Resolves brave/brave-browser#9502

Submitter Checklist:

Test Plan:

This PR modifies how publisher status and banner information is retrieved and stored on the client. Instead of downloading the entire publisher list dataset and storing that dataset in the rewards database, we will now download a small "index" of publishers and then download publisher data for individual publishers as-needed. There should be no user-visible changes, but existing test cases that involve publisher statuses or banner data should be checked for regressions.

Basic functionality test

Flags:

--rewards=staging=true --enable-logging=stderr --v=0 --vmodule='server_publisher_fetcher=1,publisher_prefix_list_updater=1'
  • Start browser with a clean profile using the flags above (additional vmodule entries can be used).
  • Enable rewards.
  • Dismiss the grant claim notification by clicking the small "x" in the rewards panel.
  • Navigate to "https://laurenwags.github.io".
    • Verify that a "verified" check mark appears on the rewards badge.
  • Open the rewards panel and click "Send a Tip".
    • Verify that the tip banner displays the correct information.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@zenparsing zenparsing force-pushed the ksmith-publishers-v4 branch 4 times, most recently from 2157e9a to 1524051 Compare July 1, 2020 15:45
@zenparsing
Copy link
Collaborator Author

  • Updated rewards_database.cc so that VACUUM is not performed if transaction could not be committed.
  • Updated rewards_database.cc a failed VACUUM is logged but not returned as an error to the caller.
  • Updated database_server_publisher_*.cc delete methods to no-op when expired records list is empty.

@zenparsing zenparsing force-pushed the ksmith-publishers-v4 branch 4 times, most recently from 24d0c02 to e073268 Compare July 4, 2020 17:10
@zenparsing
Copy link
Collaborator Author

zenparsing commented Jul 7, 2020

CI failed due to audit_deps and an unrelated macos gclient sync failure (macos verified locally).

@zenparsing zenparsing merged commit 98b60ef into master Jul 7, 2020
@zenparsing zenparsing deleted the ksmith-publishers-v4 branch July 7, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publisher list v4
7 participants