Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bookmark page favicon #5709

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Replace bookmark page favicon #5709

merged 1 commit into from
Jun 2, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jun 2, 2020

Resolves brave/brave-browser#8492

image

image

WebUI's favicon is determined by ChromeWebUIControllerFactory::GetFaviconResourceBytes()

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 1.11.x - Nightly milestone Jun 2, 2020
@simonhong simonhong self-assigned this Jun 2, 2020
@simonhong simonhong requested a review from karenkliu June 2, 2020 09:21
Copy link

@karenkliu karenkliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@simonhong simonhong merged commit 7fbbf66 into master Jun 2, 2020
@simonhong simonhong deleted the bookmark_page_favicon branch June 2, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] brave://bookmarks tab icon uses a star icon instead of Brave bookmarks icon - follow up to 2494
2 participants