-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stats: Add dtoi param to usage ping #5720
Conversation
cc @emerick I went ahead and refactored the referral code to be part of the shared stats utils. Reading the sentinel actually won't block (left comment), so it ends up working out nicely without callbacks. I'm thinking we get this merged first, and I'll rebase #5721 on master and have the referral factory use this method and pass the result to the ctor (as @simonhong has suggested for other shared code). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor comment.
Server side implementation for brave/brave-core#5720
Server side implementation for brave/brave-core#5720
* core: Add support for dtoi usage ping parameter Server side implementation for brave/brave-core#5720 * Allow developer build running testing instance
Just a reminder to please set the milestone on PRs for the milestone they are landing in. |
Verification PASSED on
Ensured that
Moved the MBP time ~14 days ahead and ensured that
|
Resolves brave/brave-browser#10061
Resolves
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.