Implement farbling levels for webaudio #5794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All relevant tests passed. CI test failure is 1 unrelated test timing out. |
bridiver
reviewed
Jun 10, 2020
| @@ -20,6 +20,36 @@ | |||
| #include "third_party/blink/renderer/platform/heap/handle.h" | |||
| #include "third_party/blink/renderer/platform/supplementable.h" | |||
|
|
|||
| #define LFSR_NEXT \ | |||
There was a problem hiding this comment.
why a define instead of a method?
There was a problem hiding this comment.
Could probably do an inline method. I just wanted to ensure it was inline and this was the first thing I thought of.
bridiver
reviewed
Jun 10, 2020
bridiver
approved these changes
Jun 10, 2020
code and tests use inline function instead of define
pilgrim-brave
force-pushed
the
mpilgrim_webaudio_v2
branch
from
92a3738
to
20ed9ac
Compare
brave-builds
pushed a commit
that referenced
this pull request
Jun 11, 2020
4 tasks
4 tasks
bsclifton
pushed a commit
that referenced
this pull request
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#9187
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.