Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated shields panel readonly view option's label (uplift to 1.11.x) #6080

Closed
wants to merge 1 commit into from
Closed

Updated shields panel readonly view option's label (uplift to 1.11.x) #6080

wants to merge 1 commit into from

Conversation

brave-builds
Copy link
Collaborator

Uplift of #6060
Resolves brave/brave-browser#10671
Resolves brave/brave-browser#10670

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team July 15, 2020 00:28
@brave-builds brave-builds self-assigned this Jul 15, 2020
@brave-builds brave-builds added this to the 1.11.x - Release milestone Jul 15, 2020
@simonhong simonhong self-assigned this Jul 15, 2020
@kjozwiak
Copy link
Member

Stopping CI to save recourses as we'll not be uplifting this into 1.11.x due to time constraints. We're slated to release on Thursday and unfortunately it's too late. Closing issue as well. We'll uplift into 1.12.x via #6079

@kjozwiak kjozwiak closed this Jul 15, 2020
@kjozwiak kjozwiak removed the request for review from a team July 15, 2020 02:11
@kjozwiak kjozwiak removed this from the 1.11.x - Release milestone Jul 15, 2020
@bsclifton bsclifton deleted the pr6060_update_shields_panel_text_1.11.x branch July 20, 2020 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @simonhong @brave-browser-releases