Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Style updates to Settings #623

Closed
wants to merge 2 commits into from
Closed

WIP: Style updates to Settings #623

wants to merge 2 commits into from

Commits on Jan 16, 2019

  1. First steps towards solving brave/brave-browser#958

    Making good progress :)
    - `Settings` header added over primary items (and restyled `Advanced` to match)
    - Padding and margin appear to match spec
    - Specified different font; page needs to be wired to properly include it
    - Sidebar has white background + borders with radius
    - Colors:
      - active items use `brandBrave` orange and bold the text
      - header incidently is now orange also
      - inactive items use `subtleInteracting`
      - `About Brave` text uses `subtle`
    - Product version (ex: 0.55.2) shown under `About Brave` along with a default icon
    - `Extensions` moved up under `Settings`
    - `Appearance` moved to last item before `Advanced`
    bsclifton authored and petemill committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    f0bfcf5 View commit details
    Browse the repository at this point in the history
  2. icon updates and light css

    - fixed render issues with current icons
    - did some light css but looped in pete and found it might be diminishing return so stopped
    - made the top banner a gradient
    - rebased against master 2019 Jan 10
    rossmoody authored and petemill committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    a4f1022 View commit details
    Browse the repository at this point in the history