Feature: Day Parting #6668
Closed
Feature: Day Parting #6668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
requested changes
Sep 21, 2020
yachtcaptain23
force-pushed
the
feature/day_parting
branch
2 times, most recently
from
bd092b4
to
b3873a0
Compare
Day Parting, which is described in bat-native-ads/data/resources/catalog-scheme.json is now added as a filter rule. Any existing fields with empty parting will not be filtered. The major note for server-side devs and reviewers is that the `dow` field will store the C++ version of day of week as a string of integers, where 0 is Sunday and 6 is Saturday. This is done to compress the catalog size for multiple days using the same time period.
yachtcaptain23
force-pushed
the
feature/day_parting
branch
from
b3873a0
to
8db62e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Day Parting, which is described in
bat-native-ads/data/resources/catalog-scheme.json
is now added as a filter rule. Any existing fields with empty parting
will not be filtered.
The major note for server-side devs and reviewers is that the
dowfield will store the C++ version of day of week as a string of integers,
where 0 is Sunday and 6 is Saturday. This is done to compress the catalog size
for multiple days using the same time period.
Closes brave/brave-browser#5234
Submitter Checklist:
npm run lint,npm run gn_check)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Tests added.
Will add test plan soon
Reviewer Checklist:
After-merge Checklist:
changes has landed on.