Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync remove other device #6732

Merged
merged 16 commits into from
Oct 29, 2020
Merged

Sync remove other device #6732

merged 16 commits into from
Oct 29, 2020

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Sep 30, 2020

Resolves brave/brave-browser#11232
Fixed brave/brave-browser#12490 for text change

Submitter Checklist:

Test Plan:

I. Sync UI is changed on Android

  1. Install browser on Android
  2. Ensure UI is as shown at Sync remove other device #6732 (comment)

II. detection of device which does not support self-delete

  1. On put into the same sync chain:
  • device A, desktop, which can do self-delete
  • device B, desktop, which cannot do self-delete
  • device C, Android, which cannot do self-delete
  1. Ensure on device A in the devices list there is no trashcan icon near device B and device C

III. All devices support self-delete

  1. Put into the same sync chain, desktop devices A and B, Android device C, which all support self-delete;
  2. Ensure on each device in the devices list other devices are displayed with trashcan icon;
  3. From device A remove devices B and C from the chain by pressing the trashcan icon near them;
  4. Ensure devices B and C are no longer in devices list on the device A;
  5. Ensure on devices B and C reset actually happened, sync settings page should want to create or connect to the sync chain;
  6. Connect again devices B and C to the same sync chain;
  7. From Android device C remove device B from the sync chain;
  8. Ensure device B is no longer in devices list on the device A and C;
  9. Ensure device B actually did self-reset;

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@AlexeyBarabash AlexeyBarabash force-pushed the sync_remove_other_device branch 4 times, most recently from 204a9e8 to a28707c Compare October 9, 2020 16:05
@AlexeyBarabash
Copy link
Contributor Author

AlexeyBarabash commented Oct 12, 2020

Here are the screenshot how it looks now, mostly the same how it was on sync v1.

Desktop:
image

Android:
(removed because below are the actual)

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src change LGTM

components/sync/driver/brave_sync_profile_sync_service.cc Outdated Show resolved Hide resolved
components/brave_sync/version_helper.cc Outdated Show resolved Hide resolved
@AlexeyBarabash
Copy link
Contributor Author

AlexeyBarabash commented Oct 22, 2020

Screenshot_20201023-003116
Screenshot_20201023-003141

Updated UI after feedback from design team

components/brave_sync/version_helper.cc Outdated Show resolved Hide resolved
components/brave_sync/version_helper.cc Outdated Show resolved Hide resolved
@AlexeyBarabash AlexeyBarabash marked this pull request as draft October 23, 2020 12:07
@darkdh darkdh requested a review from mkarolin October 26, 2020 22:31
@AlexeyBarabash
Copy link
Contributor Author

Rebased to the latest C87 master, fixed conflicts 9b67d15 .

@AlexeyBarabash AlexeyBarabash added this to the 1.18.x - Nightly milestone Oct 29, 2020
@AlexeyBarabash
Copy link
Contributor Author

All CI is green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants