Support day-parting for Brave Ads #6893
Merged
+929
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
requested changes
Oct 19, 2020
vendor/bat-native-ads/src/bat/ads/internal/catalog/catalog_daypart_info.h
Outdated
Show resolved
Hide resolved
vendor/bat-native-ads/src/bat/ads/internal/catalog/catalog_state.cc
Outdated
Show resolved
Hide resolved
...ds/src/bat/ads/internal/database/tables/creative_ad_notifications_database_table_unittest.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ads/src/bat/ads/internal/database/tables/dayparts_database_table.cc
Outdated
Show resolved
Hide resolved
...ads/src/bat/ads/internal/frequency_capping/exclusion_rules/daypart_frequency_cap_unittest.cc
Outdated
Show resolved
Hide resolved
...ads/src/bat/ads/internal/frequency_capping/exclusion_rules/daypart_frequency_cap_unittest.cc
Outdated
Show resolved
Hide resolved
...ads/src/bat/ads/internal/frequency_capping/exclusion_rules/daypart_frequency_cap_unittest.cc
Outdated
Show resolved
Hide resolved
...ads/src/bat/ads/internal/frequency_capping/exclusion_rules/daypart_frequency_cap_unittest.cc
Outdated
Show resolved
Hide resolved
...ads/src/bat/ads/internal/frequency_capping/exclusion_rules/daypart_frequency_cap_unittest.cc
Outdated
Show resolved
Hide resolved
yachtcaptain23
force-pushed
the
issues/5234
branch
from
cf5aadd
to
2a26b48
Compare
tmancey
reviewed
Oct 20, 2020
tmancey
reviewed
Oct 20, 2020
vendor/bat-native-ads/src/bat/ads/internal/database/tables/dayparts_database_table.cc
Outdated
Show resolved
Hide resolved
tmancey
reviewed
Oct 20, 2020
...t-native-ads/src/bat/ads/internal/frequency_capping/exclusion_rules/daypart_frequency_cap.cc
Outdated
Show resolved
Hide resolved
tmancey
reviewed
Oct 20, 2020
...t-native-ads/src/bat/ads/internal/frequency_capping/exclusion_rules/daypart_frequency_cap.cc
Outdated
Show resolved
Hide resolved
yachtcaptain23
force-pushed
the
issues/5234
branch
from
086bda4
to
843ed69
Compare
tmancey
approved these changes
Oct 20, 2020
yachtcaptain23
force-pushed
the
issues/5234
branch
3 times, most recently
from
d2abdaa
to
21c745c
Compare
yachtcaptain23
force-pushed
the
issues/5234
branch
from
21c745c
to
4cc30f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#5234
Submitter Checklist:
npm run lint,npm run gn_check)git rebase master(if needed).git rebase -ito squash commits (if needed).QA/YesorQA/No) to the associated issuerelease-notes/includeorrelease-notes/exclude) to the associated issueTest Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.