Increase contrast between active and inactive tabs #6900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If mouse is hovered on tab, shows close button.
* light theme #BEBEBF * dark theme #393838 * no color changes at this time for private window / with tor tab separator and custom theme
simonhong
force-pushed
the
tab_contrast
branch
from
1af4f29
to
6ead25d
Compare
simonhong
commented
Oct 20, 2020
| @@ -1,16 +1,48 @@ | |||
| diff --git a/chrome/browser/ui/views/tabs/tab_style_views.cc b/chrome/browser/ui/views/tabs/tab_style_views.cc | |||
| index 950c967b5f87a6e3f531e3155a420002a7510d3a..a9b5b74a1a5c345727c1deb631fce7fcbb2762dc 100644 | |||
| index 950c967b5f87a6e3f531e3155a420002a7510d3a..ad84681855bc39f55796c8740f490b998e2bc68a 100644 | |||
There was a problem hiding this comment.
Can't avoid patching. GM2TabStyle is defined in anonymous namespace.
There was a problem hiding this comment.
@simonhong: wasn't sure this was going to work, so had to try it out and it seems to be working. What do you think of subclassing instead like this: 4c19f3e
There was a problem hiding this comment.
Thanks @mkarolin ! Overriding CreateForTab is great :)
Updated.
* Inactive tab title has 70% opacity; on hover or focus show title at 100% opacity * Make active tab font Semibold
simonhong
force-pushed
the
tab_contrast
branch
from
6ead25d
to
6cf3dd7
Compare
|
Do tab separators seem a bit lost now? @karenkliu |
mkarolin
reviewed
Oct 20, 2020
|
@mkarolin Yep - this is the intended design. The favicon + title of inactive tabs already do a lot to differentiate between tabs, so the tab separator contrast was reduced. This will also help the active tab stand out more within the tabbar. |
|
@mkarolin Thanks for great review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#8576
Submitter Checklist:
npm run lint,npm run gn_check)git rebase master(if needed).git rebase -ito squash commits (if needed).QA/YesorQA/No) to the associated issuerelease-notes/includeorrelease-notes/exclude) to the associated issueTest Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.