Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement navigator.userAgent farbling in workers #6906

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Oct 20, 2020

Resolves brave/brave-browser#12230

Submitter Checklist:

Test Plan:

See: brave/brave-browser#12230 (comment)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pilgrim-brave pilgrim-brave requested a review from a team as a code owner October 20, 2020 21:49
@pilgrim-brave pilgrim-brave self-assigned this Oct 28, 2020
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pilgrim-brave
Copy link
Contributor Author

CI failures are unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

navigator.userAgent farbling not applied in workers
2 participants