Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of files in build list that were removed in https://github.co… #7379

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Removal of files in build list that were removed in https://github.co… #7379

merged 1 commit into from
Dec 8, 2020

Conversation

yachtcaptain23
Copy link
Contributor

@yachtcaptain23 yachtcaptain23 commented Dec 8, 2020 •
edited
Loading

Removal of files in build list that were removed in #7317

Closes brave/brave-browser#13089

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

@SergeyZhukovsky SergeyZhukovsky added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Dec 8, 2020
SergeyZhukovsky
SergeyZhukovsky approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@yachtcaptain23 yachtcaptain23 merged commit 8a0b849 into 1.19.x Dec 8, 2020
@yachtcaptain23 yachtcaptain23 deleted the bugfix/ads_assets_resource_removal branch December 8, 2020 17:14
@yachtcaptain23 yachtcaptain23 mentioned this pull request Dec 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

Assignees
No one assigned
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yachtcaptain23 @SergeyZhukovsky