Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derease font-weight for active tab #7416

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Derease font-weight for active tab #7416

merged 1 commit into from
Dec 15, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Dec 12, 2020

Resolves brave/brave-browser#13174

image

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link

@karenkliu karenkliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better! 🚀

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled to verify; LGTM++

@simonhong
Copy link
Member Author

Merged because lint failure is not related with this and test failure on iOS CI is also known issue.

@simonhong simonhong merged commit 7ea9a8c into master Dec 15, 2020
@simonhong simonhong deleted the tab_font_list branch December 15, 2020 04:47
@bsclifton bsclifton added this to the 1.20.x - Nightly milestone Dec 15, 2020
brave-builds pushed a commit that referenced this pull request Jan 5, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Jan 6, 2021

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.20.62 Chromium: 88.0.4315.7 (Official Build) nightly (64-bit)
-- | --
Revision | 9b020863b2987261f6dcd018c6b388041c035f98-refs/branch-heads/4315@{#15}
OS | Windows 10 OS Version 2009 (Build 19042.685)
Old (Darker) New (Lighter)
image image
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

decrease font-weight to medium=500 for focused tab follow up to #8576
5 participants