Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix web search from context menu in private window(also tor) #757

Merged
merged 2 commits into from
Oct 30, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Oct 29, 2018

Context menu web search should use current profile's search engine url.

Fix brave/brave-browser#1758
Fix brave/brave-browser#1037

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

yarn test brave_browser_tests --filter=BraveAutocompleteProviderClientTest.DependentServiceCheckTest

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@simonhong simonhong self-assigned this Oct 29, 2018
@simonhong simonhong changed the title Fix web search from context menu in private window(also tor) WIP: Fix web search from context menu in private window(also tor) Oct 29, 2018
Context menu web search should use current profile's search engine url.
@simonhong simonhong force-pushed the private_window_context_menu_web_search branch from 5cbdf56 to d467ca0 Compare October 29, 2018 08:04
@simonhong simonhong changed the title WIP: Fix web search from context menu in private window(also tor) Fix web search from context menu in private window(also tor) Oct 29, 2018
Check only different TemplateURLService is used on normal/incognito.
@simonhong simonhong force-pushed the private_window_context_menu_web_search branch from d467ca0 to 925d0e4 Compare October 29, 2018 08:54
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants