Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash when searching from omnibox in tor window with search engine extension (uplift to 1.23.x) #8496

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 9, 2021

Uplift of #8460
Resolves brave/brave-browser#15140

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

Fixed crash when searching from omnibox in tor window with search engine extension
@simonhong simonhong added this to the 1.23.x - Release milestone Apr 9, 2021
@simonhong simonhong requested a review from a team April 9, 2021 23:17
@simonhong simonhong requested a review from a team as a code owner April 9, 2021 23:17
@simonhong simonhong self-assigned this Apr 9, 2021
@kjozwiak
Copy link
Member

test-browser failed on macOS as per https://ci.brave.com/job/pr-brave-browser-pr8460_search_engine_extension_issues_1.23.x-macos/1/execution/node/242/log/ & https://ci.brave.com/job/pr-brave-browser-pr8460_search_engine_extension_issues_1.23.x-macos/1/execution/node/245/log/. However, these failures are known and unrelated to this specific PR.

22:09:57  6 tests crashed:
22:09:57      BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion062WithRewardsEnabled_ForSupportedLocale_ForUnsupportedLocale_RewardsShouldBeEnabled_AdsShouldBeDisabled (../../brave/components/brave_ads/browser/ads_service_browsertest.cc:1004)
22:09:57      BraveStatsUpdaterBrowserTest.StatsUpdaterMigration (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:275)
22:09:57      BraveStatsUpdaterBrowserTest.StatsUpdaterSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:154)
22:09:57      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithDefaultReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:229)
22:09:57      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:327)
22:09:57      BraveStatsUpdaterBrowserTest.StatsUpdaterThresholdSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:191)

test-browser failed on Linux as per https://ci.brave.com/job/pr-brave-browser-pr8460_search_engine_extension_issues_1.23.x-linux/2/execution/node/242/log/ & https://ci.brave.com/job/pr-brave-browser-pr8460_search_engine_extension_issues_1.23.x-linux/2/execution/node/245/log/. However, these failures are known and unrelated to this specific PR.

23:41:54  5 tests crashed:
23:41:54      BraveStatsUpdaterBrowserTest.StatsUpdaterMigration (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:275)
23:41:54      BraveStatsUpdaterBrowserTest.StatsUpdaterSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:154)
23:41:54      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithDefaultReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:229)
23:41:54      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:327)
23:41:54      BraveStatsUpdaterBrowserTest.StatsUpdaterThresholdSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:191)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.23.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8460 (comment). However, we'll still need to get brave/brave-browser#15224 addressed.

@kjozwiak kjozwiak merged commit d03430e into 1.23.x Apr 12, 2021
@kjozwiak kjozwiak deleted the pr8460_search_engine_extension_issues_1.23.x branch April 12, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants