Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to add IPFS peer servers #8839

Merged
merged 1 commit into from
May 22, 2021
Merged

Allow users to add IPFS peer servers #8839

merged 1 commit into from
May 22, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented May 18, 2021 •
edited
Loading

Resolves brave/brave-browser#15567

  • Added section to IPFS Settings page to manage peers
  • Allow to add/remove peer addresses from brave://settings/ipfs/peers
  • Added indication to restart node if the node is launched
  • Added alertion if the node cannot start

image

image

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Add/remove peers and check webui page from brave://ipfs if that peers are visible there

@spylogsster spylogsster self-assigned this May 18, 2021
@spylogsster spylogsster requested a review from a team as a code owner May 18, 2021 10:34
@spylogsster spylogsster changed the base branch from master to import-key-from-files May 18, 2021 11:58
Base automatically changed from import-key-from-files to master May 18, 2021 16:21
@spylogsster spylogsster force-pushed the peers-edit branch 7 times, most recently from 1530086 to 8c2ec98 Compare May 19, 2021 12:21
@spylogsster spylogsster requested a review from bbondy May 19, 2021 12:22
@spylogsster spylogsster force-pushed the peers-edit branch 5 times, most recently from c5b220b to 09cf254 Compare May 21, 2021 12:34
mkarolin
mkarolin approved these changes May 21, 2021
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src change LGTM

@spylogsster spylogsster merged commit 17e0faa into master May 22, 2021
@spylogsster spylogsster deleted the peers-edit branch May 22, 2021 07:00
@spylogsster spylogsster added this to the 1.27.x - Nightly milestone May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

@mkarolin mkarolin mkarolin approved these changes

Assignees

@spylogsster spylogsster

Labels
None yet
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging this pull request may close these issues.

Allow users to add IPFS peer servers
3 participants
@spylogsster @bbondy @mkarolin