-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Rewards verbose logging flag on Android #8841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Example |
Example |
Example |
---|---|---|
Cases from https://github.com/brave/brave-core/pull/8767
Verification PASSED on Samsung S10+
running Android 11
using the following build:
1.27.10 Chromium: 91.0.4472.70
- verified the STR outlined via Do not log request details for rewards external wallet session endpoints #8767 (comment)
- ensured that clicking on
Refresh
correctly populates the empty text field with the log - ensured that clicking on
Download log
correctly initiates the download process/flow - ensured that
*.uphold.com/oauth2/token
didn't appear anywhere within the log after connecting to an Uphold account- also searched for
oauth2
&oauth2/token
within the log as a double check
- also searched for
Resolves brave/brave-browser#15924
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: