Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow chrome.hid for Crypto Wallets extension #9061

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Allow chrome.hid for Crypto Wallets extension #9061

merged 1 commit into from
Jun 10, 2021

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jun 9, 2021

Resolves brave/brave-browser#16305
Description of the fix in the issue.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bbondy bbondy requested review from fmarier, onyb and mkarolin June 9, 2021 13:47
@bbondy bbondy requested a review from a team as a code owner June 9, 2021 13:47
@onyb
Copy link
Member

onyb commented Jun 9, 2021

Probably a dumb question - where did you get the 21070F3D60711361C1210B870439BE49B5D995F4 identifier from? Does it change with every new build of ethereum-remote-client?

@bbondy
Copy link
Member Author

bbondy commented Jun 9, 2021

Probably a dumb question - where did you get the 21070F3D60711361C1210B870439BE49B5D995F4 identifier from? Does it change with every new build of ethereum-remote-client?

// Ethereum Remote Client 21070F3D60711361C1210B870439BE49B5D995F4: echo -n odbfpeeihdkbihmopkbjmoonfanlbfcl | openssl sha1 | tr '[:lower:]' '[:upper:]'

You can git grep 21070F3D60711361C1210B870439BE49B5D995F4 in brave-core to see it.

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patches ++

Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enables these two extensions APIs:

  • hid
  • usbDevices

"channel": "stable",
"extension_types": ["extension"],
"allowlist": [
+ "21070F3D60711361C1210B870439BE49B5D995F4", // Ethereum Remote Client extension
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should have gone in https://github.com/brave/brave-core/blob/master/common/extensions/api/_permission_features.json or better yet we should dump the existing patch in feature_compiler.py and do a chromium_src override for AddCorePermissionFeatures in the permission_features.h generated file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose chrome.hid to Crypto Wallets extension
5 participants